Skip to content

[proxy-pallet] Add configurable proxy data for enhanced filtering with transfer limits#7938

Open
Nathy-bajo wants to merge 11 commits intoparitytech:masterfrom
Nathy-bajo:Any-proxy
Open

[proxy-pallet] Add configurable proxy data for enhanced filtering with transfer limits#7938
Nathy-bajo wants to merge 11 commits intoparitytech:masterfrom
Nathy-bajo:Any-proxy

Conversation

@Nathy-bajo
Copy link
Contributor

@Nathy-bajo Nathy-bajo commented Mar 16, 2025

Attempts to resolve #7564

This PR enhances the Proxy pallet to support configurable proxy data that can be used for advanced filtering. The main feature added is the ability to create proxies with transfer limits that reset after configurable periods, addressing security concerns where proxies could transfer all funds without restrictions.

@Nathy-bajo Nathy-bajo requested a review from a team as a code owner March 16, 2025 21:16
@Nathy-bajo Nathy-bajo marked this pull request as draft March 16, 2025 21:17
Copy link
Contributor

@xlc xlc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this code can be implemented in the proxy pallet directly.
Firstly, not every chain need (or can have) this feature, and it is not great to bloat them.
Secondly, not every chain have balances pallet (in practice, most do, but that's not a good reason to make it a requirement). And different chains have different ways to perform transfer. It is pointless to hardcoded transfer_allow_death in the pallet as many chains have alternative methods to perform token transfer.

@Nathy-bajo
Copy link
Contributor Author

I don't think this code can be implemented in the proxy pallet directly. Firstly, not every chain need (or can have) this feature, and it is not great to bloat them. Secondly, not every chain have balances pallet (in practice, most do, but that's not a good reason to make it a requirement). And different chains have different ways to perform transfer. It is pointless to hardcoded transfer_allow_death in the pallet as many chains have alternative methods to perform token transfer.

Hmm, can you explain better, please?

@xlc
Copy link
Contributor

xlc commented Mar 16, 2025

which point do you want me to explain more?

also you are not doing any options suggested here #7564 (comment)

@Nathy-bajo Nathy-bajo changed the title [proxy-pallet] Introduce a transfer limit and duration for the AnyWithLimit proxy type [proxy-pallet] Add configurable proxy data for enhanced filtering with transfer limits Jan 12, 2026
@Nathy-bajo Nathy-bajo requested a review from bkchr January 12, 2026 17:31
@Nathy-bajo
Copy link
Contributor Author

Apologies for the late response.

Please review @bkchr

}

/// Check if one `ProxyType` is a subset of another `ProxyType`.
/// Check if one `ProxyType` is a super-set of another `ProxyType`.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also fixed the typo here noticed by:

#7320 (comment)

@Nathy-bajo Nathy-bajo marked this pull request as ready for review January 12, 2026 17:42
@Nathy-bajo Nathy-bajo requested a review from xlc January 13, 2026 18:26
@Nathy-bajo
Copy link
Contributor Author

Ready for review @bkchr @xlc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Balance Transfer - Any Proxy - adding a limit / threshold

4 participants