[proxy-pallet] Add configurable proxy data for enhanced filtering with transfer limits#7938
[proxy-pallet] Add configurable proxy data for enhanced filtering with transfer limits#7938Nathy-bajo wants to merge 11 commits intoparitytech:masterfrom
Conversation
xlc
left a comment
There was a problem hiding this comment.
I don't think this code can be implemented in the proxy pallet directly.
Firstly, not every chain need (or can have) this feature, and it is not great to bloat them.
Secondly, not every chain have balances pallet (in practice, most do, but that's not a good reason to make it a requirement). And different chains have different ways to perform transfer. It is pointless to hardcoded transfer_allow_death in the pallet as many chains have alternative methods to perform token transfer.
Hmm, can you explain better, please? |
|
which point do you want me to explain more? also you are not doing any options suggested here #7564 (comment) |
|
Apologies for the late response. Please review @bkchr |
| } | ||
|
|
||
| /// Check if one `ProxyType` is a subset of another `ProxyType`. | ||
| /// Check if one `ProxyType` is a super-set of another `ProxyType`. |
There was a problem hiding this comment.
Also fixed the typo here noticed by:
Attempts to resolve #7564
This PR enhances the Proxy pallet to support configurable proxy data that can be used for advanced filtering. The main feature added is the ability to create proxies with transfer limits that reset after configurable periods, addressing security concerns where proxies could transfer all funds without restrictions.